[core] node: Check chunk size for nodes with dynamic sizes #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #2912 +/- ##
===========================================
+ Coverage 80.61% 80.76% +0.14%
===========================================
Files 55 56 +1
Lines 7692 7751 +59
===========================================
+ Hits 6201 6260 +59
Misses 1491 1491 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nodes with dynamic sizes may end up in a state where they have no chunk (e.g. because there are no input images for the previous nodes). In this case, the first chunk is the list cannot be accessed as it does not exist yet, raising an `IndexError`. We now check that there is at least an element in the chunk list before accessing it. If there is none, the default execution mode is returned instead.
cbentejac
force-pushed
the
fix/noComputedChunks
branch
from
19db216 to
69a7043
Compare
cbentejac
changed the title
IndexErrors for nodes with dynamic sizes
servantftransperfect
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nodes with dynamic sizes may end up in a state where they have no chunk (e.g. because there are no input images for the previous nodes). In this case, the first chunk is the list cannot be accessed as it does not exist yet, raising an
IndexError.We now check that there is at least an element in the chunk list before accessing it. If there is none, the default execution mode is returned instead.